remove not found __arg2 #108
Conversation
There was a problem hiding this comment.
I'm puzzled how that line got added in the first place. Looks like it was part of #105 but I'm perplexed why that was added in the first place.
Anyhow, the clippy lints are a little concerning, but I can't figure out easily why those are failing.
|
If I can help in any way, let me know. All I can tell is that removing those to lines fix it for me and it compiles and runs fine on my machines. |
|
Just as a comment (since I'm having the same issue and have "fixed" it by removing those lines) is that while I don't see any recent changes in the repository or at crates.io, apparently this exact same code was working up until yesterday? The same Github Action I've been using (that compiles and deploys a backend which uses rocket_cors) was working fine for weeks and then failed to compile yesterday. Any idea what caused the change? |
|
@secana From what I can see with regard to @tekkusan Are you using the stable or nightly compiler? |
|
Okay, I think I tracked down the clippy linter errors. It seems to be a combination of updating to Rocket 0.5-rc.2 and Hyper. I'm going to see if I can take a stab at upgrading and then layering this PR on top. |
Stable... On my local builds (which also started failing at the same time) I was using 1.60 and updated to 1.61 "just in case" (but made no difference)... On the Github Action, whatever "ubuntu-latest" has in it, but I would assume it's either 1.60 or 1.61. |
|
@tekkusan Yeah, 1.61 is what's being run by the GHA on this repo. It works when I don't run a I'm going to try to fix it, incorporate this PR, and then get this crate building with Rocket 0.5-rc.2 again 😄 |
For the record, I had been using rc.2 for a while (since I saw it was out, actually) and it was building fine (without clippy at least, which I am not running)... It literally broke last friday, and when I came here to see what was going on, I saw @secana PR. Like you said, those lines have been there "forever" so I have no clue why it would "suddenly" stop compiling 🤷♂️ |
|
@tekkusan I think I found it. It's an issue with Edit: it's this PR that fixes the positional argument issue: dtolnay/async-trait#202 |
|
Oh, I see... As a fairly new Rust coder this is way above my paygrade (in my book, async-trait is an unavoidable arcane incantation), but I do get the general idea of what happened and that commit 3 days ago indeed suggests that it was the trigger for those lines to actually start failing. |
|
@tekkusan Yep, at the very least, the removal of the lines fixes the positional arg errors, but there are more errors with regard to Hyper exports, it seems. I'll look into it and see what I can see. |
|
@secana I changed the base branch to my branch that includes updates to fix the linter and build errors. I merged your commit into it so as to not erase your contribution. Thanks so much for the PR! 🙂 |
* Update to work with latest Rocket RC
The following changes were made:
- Satisfying the `#[must_use]` annotation on the `Rocket` struct where
necessary (mostly in test code)
- Adding the `http` crate for the `HeaderName` type
- Rocket no longer exports all of `hyper` or `http`
indescriminately, so we have to be more mindful of types from
either crate that we require. Thus, this commit adds the `http`
crate to satisfy the requirement.
- Updated tests to properly return a result from a launched `Rocket`
* remove not found __arg2 (#108)
* Fix various clippy lint errors on nightly
Co-authored-by: Stefan Hausotte <stefan.hausotte@gmx.de>
|
Thank you all for the fast response!
|
Fix compilation error with
rocket_cors ="0.6.0-alpha1"androcket = "0.5.0-rc.2"onrustc 1.61.0.